fix(css_formatter): keep @charset double quote in single quote config #4404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes: #4384
@charset
must always have double quotes: https://www.w3.org/TR/css-syntax-3/#determine-the-fallback-encodingI add a param
StringLiteralParentKind
forimpl FormatLiteralStringToken
to judge if theCSS String
's parent is aCSS_CHARSET_AT_RULE
which represents the syntax like:@charset
, i refer the same util atbiome_js_formatter
.if the string is
StringLiteralParentKind::CharsetAtRule
, i will use the double quote for the string in any case, or we will execute the normal logic ofbiome_css_formatter
.Test Plan
Test case as follows: