Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(biome_css_parser): fixed css @document parser error #4350

Merged
merged 8 commits into from
Oct 23, 2024

Conversation

eryue0220
Copy link
Contributor

Summary

Closed: #4258

Test Plan

Add test cases:

@-moz-document url-prefix() {}
@-moz-document url-prefix("https://www.example.com/") {}
@-moz-document url-prefix() {
	body {
		background-color: green;
	}
}
@-moz-document url-prefix("https://www.example.com/") {
	body {
		background-color: green;
	}
}

@github-actions github-actions bot added A-Parser Area: parser L-CSS Language: CSS A-Changelog Area: changelog labels Oct 21, 2024
@eryue0220
Copy link
Contributor Author

eryue0220 commented Oct 21, 2024

@chansuke I have no idea about the ci error, it seemed that the git check didn't check any change in my pr? And I reopened a new issue just want to try could solve it or not.

Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #4350 will not alter performance

Comparing eryue0220:fix/css-moz-document (e245a76) with main (e3e37ab)

Summary

✅ 101 untouched benchmarks

@eryue0220 eryue0220 marked this pull request as draft October 21, 2024 06:29
@github-actions github-actions bot added the A-Tooling Area: internal tools label Oct 23, 2024
@eryue0220 eryue0220 marked this pull request as ready for review October 23, 2024 04:27
@ematipico ematipico merged commit d59d43d into biomejs:main Oct 23, 2024
13 checks passed
@eryue0220 eryue0220 deleted the fix/css-moz-document branch October 23, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 css parse error with @-moz-document url-prefix()
2 participants