Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): noUnknownFunction support calc-size function #4283

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

fireairforce
Copy link
Member

Summary

closes: #4212

Test Plan

@github-actions github-actions bot added A-Linter Area: linter L-CSS Language: CSS labels Oct 14, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the changelog?

@github-actions github-actions bot added the A-Changelog Area: changelog label Oct 14, 2024
@fireairforce
Copy link
Member Author

yes, i updated now~

@ematipico ematipico merged commit 6e1170e into biomejs:main Oct 14, 2024
11 checks passed
@fireairforce fireairforce deleted the fix-4214 branch October 14, 2024 06:56
Copy link

codspeed-hq bot commented Oct 14, 2024

CodSpeed Performance Report

Merging #4283 will improve performances by 19.34%

Comparing fireairforce:fix-4214 (dcc1556) with main (2342984)

Summary

⚡ 3 improvements
✅ 102 untouched benchmarks

Benchmarks breakdown

Benchmark main fireairforce:fix-4214 Change
pure_9395922602181450299.css[cached] 3.6 ms 3.3 ms +7.54%
big5-added_15586211152145260264.json[uncached] 652.8 µs 547.1 µs +19.34%
db_17847247775464589309.json[cached] 14.3 ms 13 ms +10.72%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 calc-size in CSS linter not supported
2 participants