Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): don't panic when escaping a string #4186

Merged
merged 1 commit into from
Oct 6, 2024
Merged

fix(js): don't panic when escaping a string #4186

merged 1 commit into from
Oct 6, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Oct 6, 2024

Summary

Fix #4181

Test Plan

I added some tests to avoid any regression.

@github-actions github-actions bot added L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Oct 6, 2024
Copy link
Contributor

github-actions bot commented Oct 6, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48544 48544 0
Passed 47353 47353 0
Failed 1191 1191 0
Panics 0 0 0
Coverage 97.55% 97.55% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6576 6576 0
Passed 2204 2204 0
Failed 4372 4372 0
Panics 0 0 0
Coverage 33.52% 33.52% 0.00%

ts/babel

Test result main count This PR count Difference
Total 680 680 0
Passed 608 608 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.41% 89.41% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18473 18473 0
Passed 14146 14146 0
Failed 4327 4327 0
Panics 0 0 0
Coverage 76.58% 76.58% 0.00%

@Conaclos Conaclos merged commit 797093d into main Oct 6, 2024
12 checks passed
@Conaclos Conaclos deleted the conaclos/4181 branch October 6, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 biome lint panics when encountering multi-byte characters
2 participants