fix(lint/useTemplate): preserve leading non-string addition

biomejs · Aug 28, 2023 · 982ac70 · 982ac70
1 parent b0cedb8
commit 982ac70
Show file tree

Hide file tree

Showing 19 changed files with 934 additions and 735 deletions.
diff --git a/crates/rome_js_analyze/src/analyzers/style/use_template.rs b/crates/rome_js_analyze/src/analyzers/style/use_template.rs
diff --git a/crates/rome_js_analyze/src/utils.rs b/crates/rome_js_analyze/src/utils.rs
@@ -9,7 +9,6 @@ use std::iter;
 
 pub mod batch;
 pub mod case;
-pub mod escape;
 pub mod rename;
 #[cfg(test)]
 pub mod tests;

diff --git a/crates/rome_js_analyze/tests/specs/style/useTemplate/invalid.js b/crates/rome_js_analyze/tests/specs/style/useTemplate/invalid.js
@@ -0,0 +1,51 @@
+foo + 'baz';
+
+1 * 2 + 'foo';
+
+1 + 2 + 3 + "px" + 4 + 5;
+
+a + b + c + 'px' + d + e;
+
+1 + 'foo' + 2 + 'bar' + 'baz' + 3;
+
+(1 + 'foo') * 2;
+
+1 * (2 + 'foo') + 'bar';
+
+'foo' + 1;
+
+'foo' + `bar${`baz${'bat' + 'bam'}`}` + 'boo';
+
+'foo' + 1 + 2;
+
+1 + '2' - 3;
+
+foo() + ' bar';
+
+foo() + '\n';
+
+1 * /**leading*/'foo'    /**trailing */                   + 'bar';
+
+// strings including `${`
+
+'${foo.' + bar + '.baz}';
+
+'foo: ${bar.' + baz + '.bat}';
+
+'foo: `bar.' + baz + '.bat}';
+
+'${foo}: `bar.' + baz + '.bat}';
+
+'foo: ${bar.' + baz + '.bat}';
+
+'foo: `bar.' + baz + '.bat}';
+
+'foo: \\${bar.' + baz + '.bat}';
+
+'foo: \\${bar.' + baz + '.bat}';
+
+// parentheses
+
+const x = a + ("b") + c;
+
+("a") + (b) + ("c");