wip

src/commands/start.ts → src/commands.ts

@@ -1,21 +1,27 @@
-import { restart, start, stop } from "../extension";
+import { restart, start, stop } from "./extension";
 
 /**
  * Starts the Biome extension
+ *
+ * This command is exposed to the users as a command in the command palette.
  */
 export const startCommand = async () => {
 	await start();
 };
 
 /**
  * Stops the Biome extension
+ *
+ * This command is exposed to the users as a command in the command palette.
  */
 export const stopCommand = async () => {
 	await stop();
 };
 
 /**
  * Restarts the Biome extension
+ *
+ * This command is exposed to the users as a command in the command palette.
  */
 export const restartCommand = async () => {
 	await restart();

src/extension.ts

@@ -5,7 +5,7 @@ import {
 	window,
 	workspace,
 } from "vscode";
-import { restartCommand, startCommand, stopCommand } from "./commands/start";
+import { restartCommand, startCommand, stopCommand } from "./commands";
 import { error, info } from "./logger";
 import { type Project, createProjects } from "./project";
 import { createSession } from "./session";
@@ -48,6 +48,8 @@ export const createExtension = async (
 		return;
 	}
 
+	state.state = "initializing";
+
 	// Start the extension
 	await start();
 };
@@ -79,6 +81,7 @@ const setupGlobalSession = async () => {
 		if (hasUntitledDocuments() && !state.globalSession) {
 			info("Found untitle files, creating global session.");
 			state.globalSession = await createSession();
+			state.globalSession?.client.start();
 		}
 	});
 
@@ -108,6 +111,8 @@ const setupProjectSessions = async (projects: Project[]) => {
 				`Created session for project ${project.path} in workspace ${project.folder.name}.`,
 			);
 			state.sessions.set(project, session);
+
+			await session.client.start();
 		} else {
 			error(
 				`Failed to create session for project ${project.path} in workspace ${project.folder.name}.`,
@@ -121,24 +126,32 @@ const setupProjectSessions = async (projects: Project[]) => {
  */
 export const start = async () => {
 	info("🚀 Starting Biome extension");
+	state.state = "starting";
 	window.withProgress(
 		{
 			title: "Starting Biome extension",
 			location: ProgressLocation.Notification,
 		},
 		async () => {
-			await setupGlobalSession();
-			const projects = await createProjects();
-			await setupProjectSessions(projects);
+			try {
+				await setupGlobalSession();
+				const projects = await createProjects();
+				await setupProjectSessions(projects);
+			} catch (e) {
+				error("Failed to start Biome extension", error);
+				state.state = "error";
+			}
 		},
 	);
+	state.state = "started";
 };
 
 /**
  * Stops the biome extension
  */
 export const stop = async () => {
 	info("Stopping Biome extension");
+	state.state = "stopping";
 	window.withProgress(
 		{
 			title: "Stopping Biome extension",
@@ -152,6 +165,7 @@ export const stop = async () => {
 			state.sessions.clear();
 		},
 	);
+	state.state = "stopped";
 };
 
 /**

src/session.ts

@@ -1,5 +1,6 @@
 import { type LogOutputChannel, type Uri, window } from "vscode";
 import {
+	type DocumentFilter,
 	LanguageClient,
 	type LanguageClientOptions,
 	type ServerOptions,
@@ -60,6 +61,9 @@ const createLanguageClient = (bin: Uri, project?: Project) => {
 	const serverOptions: ServerOptions = {
 		command: bin.fsPath,
 		transport: TransportKind.stdio,
+		options: {
+			cwd: project.path.fsPath,
+		},
 		args,
 	};
 
@@ -143,7 +147,7 @@ const createLspTraceLogger = (project?: Project): LogOutputChannel => {
  * project is specified, the document selector will match files that have
  * not yet been saved to disk (untitled).
  */
-const createDocumentSelector = (project?: Project) => {
+const createDocumentSelector = (project?: Project): DocumentFilter[] => {
 	return supportedLanguages.map((language) => ({
 		language,
 		scheme: project ? "file" : "untitled",

src/state.ts

@@ -1,5 +1,7 @@
+import { workspace } from "vscode";
 import type { Project } from "./project";
 import type { Session } from "./session";
+import { updateStatusBar } from "./ui/status-bar/status-bar";
 
 export type State = {
 	/**
@@ -16,7 +18,8 @@ export type State = {
 		| "started"
 		| "running"
 		| "stopping"
-		| "stopped";
+		| "stopped"
+		| "error";
 
 	/**
 	 * The Biome project that is currently active
@@ -32,8 +35,25 @@ export type State = {
 	globalSession?: Session;
 };
 
-export const state: State = {
+const _state: State = {
 	state: "initializing",
 	sessions: new Map<Project, Session>([]),
 	globalSession: undefined,
 } as State;
+
+/**
+ * The state of the extension
+ *
+ * This state is a proxy to the actual state of the extension, which allows us
+ * to listen for changes to the state and update the status bar accordingly.
+ */
+export const state = new Proxy(_state, {
+	get: (target, prop) => Reflect.get(target, prop),
+	set: (target, prop, value): boolean => {
+		if (Reflect.set(target, prop, value)) {
+			updateStatusBar();
+			return true;
+		}
+		return false;
+	},
+});

src/ui/status-bar/status-bar.ts

@@ -1,12 +1,17 @@
-import { StatusBarAlignment, type StatusBarItem, window } from "vscode";
+import {
+	StatusBarAlignment,
+	type StatusBarItem,
+	window,
+	workspace,
+} from "vscode";
 import { type State, state } from "../../state";
 import { config } from "../../utils";
 
 export type StatusBar = {
 	item: StatusBarItem;
 };
 
-const createStatusBar = () => {
+const createStatusBar = (): StatusBar => {
 	const item = window.createStatusBarItem(
 		"biome",
 		StatusBarAlignment.Right,
@@ -17,6 +22,10 @@ const createStatusBar = () => {
 };
 
 export const updateStatusBar = () => {
+	if (!state) {
+		return;
+	}
+
 	if (!config("enable", { default: true }) || state.state === "disabled") {
 		statusBar.item.hide();
 		return;
@@ -60,6 +69,8 @@ const getStateTooltip = () => {
 			return "Stopping";
 		case "stopped":
 			return "Stopped";
+		case "error":
+			return "Error";
 		default:
 			return "Biome";
 	}
@@ -77,6 +88,8 @@ const getStateIcon = (state: State): string => {
 			return "$(sync~spin)";
 		case "stopped":
 			return "$(x)";
+		case "error":
+			return "$(error)";
 		default:
 			return "$(question)";
 	}

test/fixtures/biome.jsonc

@@ -0,0 +1,20 @@
+/**
+ * This file exists as a stopgap to ensure that Biome does not attempt
+ * resolve the configuration files in parent directories for the test
+ * fixtures that do not have their own configuration files.
+ *
+ * This is necessary because some configuration options may have an
+ * impact on the behavior of the test fixtures, notably, in the root
+ * of this repo we ignore files in the `test/fixtures` directory to
+ * ensure we don't format them accidentally. Unfortunately, this
+ * means that when opening test fixtures that do not have their own
+ * configuration file as workspace folders, the configuration options
+ * in the root of the repo will be applied to them, prevent us from
+ * running the tests reliably.
+ *
+ * Test fixtures that do have their own configuration files will be
+ * resolved as expected.
+ *
+ * Keep this configuration empty.
+ */
+{}

test/fixtures/multi-root-workspace/bar/packages/frontend/frontend.js

@@ -0,0 +1 @@
+const a = 1;

test/fixtures/multi-root-workspace/foo/package.json

@@ -3,5 +3,6 @@
 	"version": "0.0.0",
 	"devDependencies": {
 		"@biomejs/biome": "^1.8.1"
+
 	}
 }

test/fixtures/multi-root-workspace/foo/packages/backend/backend.js

@@ -0,0 +1 @@
+const a = 1