Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix bold fonts on Qt5 on Macs (apply QTBUG-58610 fix only on Windows) #315

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

markotoplak
Copy link
Member

@markotoplak markotoplak commented Nov 19, 2024

Fixes #314. I did not test how this looks on Windows, but it should not change anything since both 32 and 64-bit windows are win32

@markotoplak markotoplak changed the title Apply QTBUG-58610 fix only on Windows [FIX] Fix bold fonts on Qt5 on Macs (apply QTBUG-58610 fix only on Windows) Nov 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.59%. Comparing base (cc3eacb) to head (9015f52).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #315   +/-   ##
=======================================
  Coverage   76.59%   76.59%           
=======================================
  Files         100      100           
  Lines       21217    21217           
=======================================
  Hits        16252    16252           
  Misses       4965     4965           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janezd
Copy link
Contributor

janezd commented Nov 19, 2024

I "fixed" it by setting QT_API to pyqt6. In every session. Annoying.

Thanks!

@janezd janezd self-assigned this Nov 22, 2024
@janezd janezd merged commit 8a08552 into biolab:master Nov 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Almost all fonts are bold (Mac + Qt5)
3 participants