-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin/move test resources #13
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=======================================
Coverage ? 88.41%
=======================================
Files ? 6
Lines ? 302
Branches ? 0
=======================================
Hits ? 267
Misses ? 35
Partials ? 0 ☔ View full report in Codecov by Sentry. |
- uses: aws-actions/configure-aws-credentials@v3 | ||
with: | ||
role-to-assume: arn:aws:iam::978220035532:role/bioio_github | ||
role-session-name: bioio-tifffile-${{ github.sha }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there something about the role-session-name or the hash that restricts the set of files to only relevant ones for bioio-tifffile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope! This would have access to all the files in the bucket (i.e. all bioio-devs test files), but when it comes to downloading them for each repository they are packaged separately by quilt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see now, in download_test_resources. Thanks!
f9a4168
to
bfdb9cc
Compare
Moves test resources to new bucket