Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin/move test resources #13

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Admin/move test resources #13

merged 4 commits into from
Dec 1, 2023

Conversation

SeanLeRoy
Copy link
Contributor

@SeanLeRoy SeanLeRoy commented Nov 29, 2023

Moves test resources to new bucket

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@cf43f53). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage        ?   88.41%           
=======================================
  Files           ?        6           
  Lines           ?      302           
  Branches        ?        0           
=======================================
  Hits            ?      267           
  Misses          ?       35           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SeanLeRoy SeanLeRoy marked this pull request as ready for review December 1, 2023 18:58
@SeanLeRoy SeanLeRoy requested a review from a team as a code owner December 1, 2023 18:58
- uses: aws-actions/configure-aws-credentials@v3
with:
role-to-assume: arn:aws:iam::978220035532:role/bioio_github
role-session-name: bioio-tifffile-${{ github.sha }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there something about the role-session-name or the hash that restricts the set of files to only relevant ones for bioio-tifffile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! This would have access to all the files in the bucket (i.e. all bioio-devs test files), but when it comes to downloading them for each repository they are packaged separately by quilt.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see now, in download_test_resources. Thanks!

@SeanLeRoy SeanLeRoy force-pushed the admin/move-test-resources branch from f9a4168 to bfdb9cc Compare December 1, 2023 19:28
@SeanLeRoy SeanLeRoy merged commit 054cb03 into main Dec 1, 2023
10 of 11 checks passed
@SeanLeRoy SeanLeRoy deleted the admin/move-test-resources branch December 1, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants