Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorize Weighted unifrac for CPUs #9

Merged
merged 12 commits into from
Oct 4, 2022

Conversation

sfiligoi
Copy link
Collaborator

@sfiligoi sfiligoi commented Oct 4, 2022

Explicitly vectorize the Weighted Unifrac variants on the CPU, since the compiler is not able to do it on its own, due to complex logic in the loop.

@sfiligoi
Copy link
Collaborator Author

sfiligoi commented Oct 4, 2022

The runtime for EMP weighted_normalized_fp32 on a AMD EPYC 7302
is reduced from ~690s to ~550s

@sfiligoi
Copy link
Collaborator Author

sfiligoi commented Oct 4, 2022

CC @wasade

@wasade
Copy link
Member

wasade commented Oct 4, 2022

Thanks!! I didn't see anything obvious, assuming this generates identical output?

@sfiligoi
Copy link
Collaborator Author

sfiligoi commented Oct 4, 2022

Yes, It generates identical output.

@sfiligoi sfiligoi merged commit cd00785 into biocore:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants