Use plain mkstemp() if O_NOATIME is not available #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Will merge if tests pass |
|
Thanks! Unfortunately:
However this Ubuntu test failure appears to be unrelated to this code change… |
|
Good spot, thanks. @sfiligoi, any idea what may be going on with the failure here? |
|
Looks like the dependency changed a little bit with never versions of gcc in conda. |
|
Thanks! |
|
@jmarshall Please pull the latests main. The build works again there. |
Platforms that don't have O_NOATIME (i.e., non-Linux) may not have mkostemp() either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms that don't have the Linux-specific
O_NOATIMEmay not have the non-POSIXmkostemp()either.For example, macOS prior to version 10.12 did not provide
mkostemp().The code needs
mkostemponly so that it can specifymkostemp(…, O_NOATIME). IfO_NOATIMEis not available, it could equivalently use the POSIX standardmkstemp()instead. For your consideration, this PR does that.See also bioconda/bioconda-recipes#37162, which applies this patch to Bioconda's unifrac-binaries package to reinstate it after previous macOS build failures due to this missing function.