Add support for subsampling without replacement #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @wasade |
|
Computing PCOA of EMP with n=200 subsampling without replacement: Using ssu with 100 subsampling: |
wasade
reviewed
Jun 9, 2023
| // use persistent buffer to minimize allocation costs | ||
| std::vector<uint64_t> data; // original values | ||
| std::vector<uint32_t> sample_out; // random output buffer | ||
| std::vector<uint32_t> data_out; // computed values |
There was a problem hiding this comment.
Does this mean the max count for a given feature in a given sample is 2**32?
There was a problem hiding this comment.
Sorta....
This is the output counts, not the input counts.
Because n is 32-bit, and the output cannot be larger than n.
Input counts are 64-bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.