-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #55 from sfiligoi/unnormalizedunweighted_241217
Add unweighted_unnormalized method
- Loading branch information
Showing
12 changed files
with
442 additions
and
57 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
f93973b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sfiligoi, everything else looks good except this last step for compiling:
cd src && make api
make[1]: Entering directory '/storage/coda1/p-ktk3/0/jzhao399/rich_project/apps/unifrac-binaries/src'
h5c++ -shared -fopenmp -o libssu.so tree.o biom.o biom_inmem.o biom_subsampled.o tsv.o unifrac_internal.o unifrac_cmp_cpu.o unifrac.o cmd.o skbio_alt.o api.o -lc -llz4 -llapacke -lcblas -lgfortran -lquadmath -L/lib -noshlib -lhdf5_cpp -lhdf5_hl_cpp -lhdf5_hl -lhdf5
/storage/pace-apps/spack/packages/linux-rhel9-x86_64_v3/gcc-12.3.0/hdf5-1.14.3-esvmamt2aiboaxi5x7kmynb4o4vxu3nl/h5c++
dir is /storage/pace-apps/spack/packages/linux-rhel9-x86_64_v3/gcc-12.3.0/hdf5-1.14.3-esvmamt2aiboaxi5x7kmynb4o4vxu3nl
g++: error: unrecognized command-line option '-noshlib'; did you mean '-nostdli'?
make[1]: *** [Makefile:162: libssu.so] Error 1
make[1]: Leaving directory '/storage/coda1/p-ktk3/0/jzhao399/rich_project_bio-konstantinidis/apps/unifrac-binaries/src'
make: *** [Makefile:34: api] Error 2
I am using hdf5 v1.14.3, gnu gcc/g++ 12.3. Did you see this problem before?
Thanks,
Jianshu
f93973b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jianshu93 Not sure what went wrong in your case.
Are you building on Linux?
That said, we definitely recommend using compilers and support libraries from conda (as described in the README) and that seems to work:
f93973b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f93973b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sfiligoi,
I do not know why, after using conda: (unifrac-binaries) [jzhao399@login-phoenix-rh9-1 unifrac-binaries]$ make api && make main
cd src && make api
make[1]: Entering directory '/storage/coda1/p-ktk3/0/jzhao399/rich_project_bio-konstantinidis/apps/unifrac-binaries/src'
h5c++ -shared -fopenmp -o libssu.so tree.o biom.o biom_inmem.o biom_subsampled.o tsv.o unifrac_internal.o unifrac_cmp_cpu.o unifrac.o cmd.o skbio_alt.o api.o -lc -llz4 -llapacke -lcblas -lgfortran -lquadmath -L/storage/home/hcoda1/4/jzhao399/p-ktk3-0/miniconda3/envs/unifrac-binaries/lib -noshlib -lhdf5_cpp -lhdf5_hl_cpp -lhdf5_hl -lhdf5
make[1]: Leaving directory '/storage/coda1/p-ktk3/0/jzhao399/rich_project_bio-konstantinidis/apps/unifrac-binaries/src'
cd src && make main
make[1]: Entering directory '/storage/coda1/p-ktk3/0/jzhao399/rich_project_bio-konstantinidis/apps/unifrac-binaries/src'
h5c++ -DNDEBUG -D_FORTIFY_SOURCE=2 -O2 -isystem /storage/home/hcoda1/4/jzhao399/p-ktk3-0/miniconda3/envs/unifrac-binaries/include -fopenmp -march=native -mtune=native -Wextra -Wno-unused-parameter -Wall -std=c++17 -pedantic -I. -Ofast -fPIC -L/storage/home/hcoda1/4/jzhao399/p-ktk3-0/miniconda3/envs/unifrac-binaries/lib su.cpp -o ssu tree.o biom.o biom_inmem.o biom_subsampled.o tsv.o unifrac_internal.o unifrac_cmp_cpu.o unifrac.o cmd.o skbio_alt.o api.o -lhdf5_cpp -llz4 -llapacke -lcblas -lgfortran -lquadmath -lpthread
/storage/coda1/p-ktk3/0/jzhao399/miniconda3/envs/unifrac-binaries/bin/../lib/gcc/x86_64-conda-linux-gnu/14.2.0/../../../../x86_64-conda-linux-gnu/bin/ld: biom.o: in function
su::biom::set_nnz() [clone .localalias]': biom.cpp:(.text+0x527): undefined reference to
H5::DataSpace::getSimpleExtentDims(unsigned long*, unsigned long*) const'/storage/coda1/p-ktk3/0/jzhao399/miniconda3/envs/unifrac-binaries/bin/../lib/gcc/x86_64-conda-linux-gnu/14.2.0/../../../../x86_64-conda-linux-gnu/bin/ld: biom.o: in function
su::biom::load_ids(char const*, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&) [clone .localalias]': biom.cpp:(.text+0x614): undefined reference to
H5::DataSpace::getSimpleExtentDims(unsigned long*, unsigned long*) const'/storage/coda1/p-ktk3/0/jzhao399/miniconda3/envs/unifrac-binaries/bin/../lib/gcc/x86_64-conda-linux-gnu/14.2.0/../../../../x86_64-conda-linux-gnu/bin/ld: biom.o: in function
su::biom::load_indptr(char const*, std::vector<unsigned int, std::allocator<unsigned int> >&) [clone .localalias]': biom.cpp:(.text+0xb7f): undefined reference to
H5::DataSpace::getSimpleExtentDims(unsigned long*, unsigned long*) const'/storage/coda1/p-ktk3/0/jzhao399/miniconda3/envs/unifrac-binaries/bin/../lib/gcc/x86_64-conda-linux-gnu/14.2.0/../../../../x86_64-conda-linux-gnu/bin/ld: biom.o: in function
su::biom::get_obs_data_direct(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int*&, double*&) [clone .localalias]': biom.cpp:(.text+0xec4): undefined reference to
H5::DataSpace::DataSpace(int, unsigned long const*, unsigned long const*)'/storage/coda1/p-ktk3/0/jzhao399/miniconda3/envs/unifrac-binaries/bin/../lib/gcc/x86_64-conda-linux-gnu/14.2.0/../../../../x86_64-conda-linux-gnu/bin/ld: biom.cpp:(.text+0xedb): undefined reference to
H5::DataSpace::DataSpace(int, unsigned long const*, unsigned long const*)' /storage/coda1/p-ktk3/0/jzhao399/miniconda3/envs/unifrac-binaries/bin/../lib/gcc/x86_64-conda-linux-gnu/14.2.0/../../../../x86_64-conda-linux-gnu/bin/ld: biom.cpp:(.text+0xef6): undefined reference to
H5::DataSpace::selectHyperslab(H5S_seloper_t, unsigned long const*, unsigned long const*, unsigned long const*, unsigned long const*) const'/storage/coda1/p-ktk3/0/jzhao399/miniconda3/envs/unifrac-binaries/bin/../lib/gcc/x86_64-conda-linux-gnu/14.2.0/../../../../x86_64-conda-linux-gnu/bin/ld: biom.cpp:(.text+0xf0c): undefined reference to
H5::DataSpace::selectHyperslab(H5S_seloper_t, unsigned long const*, unsigned long const*, unsigned long const*, unsigned long const*) const' /storage/coda1/p-ktk3/0/jzhao399/miniconda3/envs/unifrac-binaries/bin/../lib/gcc/x86_64-conda-linux-gnu/14.2.0/../../../../x86_64-conda-linux-gnu/bin/ld: biom.o: in function
su::biom::get_sample_data_direct(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, unsigned int*&, double*&)':biom.cpp:(.text+0x16c4): undefined reference to
H5::DataSpace::DataSpace(int, unsigned long const*, unsigned long const*)' /storage/coda1/p-ktk3/0/jzhao399/miniconda3/envs/unifrac-binaries/bin/../lib/gcc/x86_64-conda-linux-gnu/14.2.0/../../../../x86_64-conda-linux-gnu/bin/ld: biom.cpp:(.text+0x16db): undefined reference to
H5::DataSpace::DataSpace(int, unsigned long const*, unsigned long const*)'/storage/coda1/p-ktk3/0/jzhao399/miniconda3/envs/unifrac-binaries/bin/../lib/gcc/x86_64-conda-linux-gnu/14.2.0/../../../../x86_64-conda-linux-gnu/bin/ld: biom.cpp:(.text+0x16f6): undefined reference to
H5::DataSpace::selectHyperslab(H5S_seloper_t, unsigned long const*, unsigned long const*, unsigned long const*, unsigned long const*) const' /storage/coda1/p-ktk3/0/jzhao399/miniconda3/envs/unifrac-binaries/bin/../lib/gcc/x86_64-conda-linux-gnu/14.2.0/../../../../x86_64-conda-linux-gnu/bin/ld: biom.cpp:(.text+0x170c): undefined reference to
H5::DataSpace::selectHyperslab(H5S_seloper_t, unsigned long const*, unsigned long const*, unsigned long const*, unsigned long const*) const'/storage/coda1/p-ktk3/0/jzhao399/miniconda3/envs/unifrac-binaries/bin/../lib/gcc/x86_64-conda-linux-gnu/14.2.0/../../../../x86_64-conda-linux-gnu/bin/ld: unifrac_cmp_cpu.o: in function
su_cpu::UnifracGeneralizedTask<double>::_run(unsigned int) [clone ._omp_fn.0]': unifrac_cmp.cpp:(.text+0x6ac): undefined reference to
_ZGVdN4vv_pow'/storage/coda1/p-ktk3/0/jzhao399/miniconda3/envs/unifrac-binaries/bin/../lib/gcc/x86_64-conda-linux-gnu/14.2.0/../../../../x86_64-conda-linux-gnu/bin/ld: unifrac_cmp.cpp:(.text+0x859): undefined reference to
_ZGVbN2vv_pow' /storage/coda1/p-ktk3/0/jzhao399/miniconda3/envs/unifrac-binaries/bin/../lib/gcc/x86_64-conda-linux-gnu/14.2.0/../../../../x86_64-conda-linux-gnu/bin/ld: unifrac_cmp_cpu.o: in function
su_cpu::UnifracGeneralizedTask::_run(unsigned int) [clone ._omp_fn.0]':unifrac_cmp.cpp:(.text+0x11ab): undefined reference to
_ZGVdN8vv_powf' /storage/coda1/p-ktk3/0/jzhao399/miniconda3/envs/unifrac-binaries/bin/../lib/gcc/x86_64-conda-linux-gnu/14.2.0/../../../../x86_64-conda-linux-gnu/bin/ld: unifrac_cmp.cpp:(.text+0x13d6): undefined reference to
_ZGVbN4vv_powf'collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:156: ssu] Error 1
make[1]: Leaving directory '/storage/coda1/p-ktk3/0/jzhao399/rich_project_bio-konstantinidis/apps/unifrac-binaries/src'
make: *** [Makefile:51: main] Error 2
Can you please share a pre-built binary with me (linux only), perhaps statically linked (CPU only)?
Thanks,
Jianshu