Merge pull request #39 from sfiligoi/memleak_PropStack_2304

Fix memory leak
biocore · Apr 28, 2023 · badf2e1 · badf2e1
2 parents 856c23c + 83264a7
commit badf2e1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/biom_subsampled.cpp b/src/biom_subsampled.cpp
@@ -73,6 +73,7 @@ linked_sparse_transposed::linked_sparse_transposed(sparse_data &other)
 
 linked_sparse_transposed::~linked_sparse_transposed() {
     if(obs_data_resident != NULL) {
+        for (uint32_t i=0; i<n_obs; i++) free(obs_data_resident[i]);
         free(obs_data_resident);
         obs_data_resident = NULL;
     }

diff --git a/src/unifrac_internal.cpp b/src/unifrac_internal.cpp
@@ -88,7 +88,7 @@ PropStack<TFloat>::PropStack(uint32_t vecsize)
 template<class TFloat>
 PropStack<TFloat>::~PropStack() {
     // drain stack
-    for(unsigned int i = 0; i < prop_stack.size(); i++) {
+    while (!prop_stack.empty()) {
         TFloat *vec = prop_stack.top();
         prop_stack.pop();
         free(vec);