Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-decorating a tree decorated tree with support values #24

Open
donovan-h-parks opened this issue Feb 15, 2016 · 1 comment
Open

Re-decorating a tree decorated tree with support values #24

donovan-h-parks opened this issue Feb 15, 2016 · 1 comment

Comments

@donovan-h-parks
Copy link
Contributor

Some undesired behaviour can occur when trying to re-decorate a tree that already contains internal labels. This seems especially true when nodes have support values. We have observed that redecorated nodes loss their support values. It is also unclear if the pre-existing labels are removed or retained. Stripping pre-existing internal labels, while retaining the support values, allows a tree to be cleanly re-decorated. Perhaps a check for pre-existing labels would be good along with a new function for stripping pre-existing labels.

@wasade
Copy link
Member

wasade commented Feb 15, 2016

Unfortunately, this was a bit difficult to resolve previously as there
isn't a standard way to represent metadata on internal nodes. I like the
check + function idea

On Mon, Feb 15, 2016 at 11:30 AM, Donovan Parks notifications@github.com
wrote:

Some undesired behaviour can occur when trying to re-decorate a tree that
already contains internal labels. This seems especially true when nodes
have support values. We have observed that redecorated nodes loss their
support values. It is also unclear if the pre-existing labels are removed
or retained. Stripping pre-existing internal labels, while retaining the
support values, allows a tree to be cleanly re-decorated. Perhaps a check
for pre-existing labels would be good along with a new function for
stripping pre-existing labels.


Reply to this email directly or view it on GitHub
#24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants