Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -gnps option to standalone script #105

Merged
merged 7 commits into from
May 13, 2019
Merged

Add -gnps option to standalone script #105

merged 7 commits into from
May 13, 2019

Conversation

fedarko
Copy link
Collaborator

@fedarko fedarko commented May 13, 2019

Would like to eventually add some tests to this; it's explicitly labelled as an experimental feature in the README, so ok to merge into master IMO.

fedarko added 7 commits May 10, 2019 19:57
Progress towards #49.

Might make this standalone-rrv-exclusive for now?
:D :D :D

gotta give credit to whomstever originally wrote that one function
tho (right now it's mentioned that I got it from Julia's notebook)

MIIIGHT be worth integrating this with Q2 side of things but that
might be a whole other can of worms
Since the GNPS feature metadata file I've been working with doesn't
validate as a Q2 metadata file. I'm sure it'll be possible to get
this working with QIIME 2 in the future, though -- just a matter
of seeing how format stuff works out and adjusting the code
accordingly.
@fedarko fedarko merged commit 7ba5207 into master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant