Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing #77 #78

Merged
merged 3 commits into from
Dec 3, 2016
Merged

Addressing #77 #78

merged 3 commits into from
Dec 3, 2016

Conversation

mortonjt
Copy link
Collaborator

@mortonjt mortonjt commented Dec 2, 2016 •
edited
Loading

This is required for compatibility with qiime2

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 99.338% when pulling b6be1ba on mortonjt:io_filehandle into 7f6a06b on biocore:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 99.669% when pulling 470603f on mortonjt:io_filehandle into 7f6a06b on biocore:master.

@mortonjt
Copy link
Collaborator Author

mortonjt commented Dec 2, 2016

Ok, this is ready to merge! @jkanbar want to do a review / merge this one?

@mortonjt
Copy link
Collaborator Author

mortonjt commented Dec 3, 2016

@qiyunzhu would you also like to look at this?

@qiyunzhu
Copy link
Collaborator

qiyunzhu commented Dec 3, 2016

I have discussed with @mortonjt . I think it is ready to merge.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 99.669% when pulling 39f5c87 on mortonjt:io_filehandle into 7f6a06b on biocore:master.

@qiyunzhu qiyunzhu merged commit 6a311a0 into biocore:master Dec 3, 2016
@mortonjt
Copy link
Collaborator Author

mortonjt commented Dec 3, 2016

Thanks!

@mortonjt mortonjt deleted the io_filehandle branch April 6, 2017 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mortonjt @coveralls @qiyunzhu