Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing sparse matching #291

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Fixing sparse matching #291

merged 2 commits into from
Jul 8, 2021

Conversation

mortonjt
Copy link
Collaborator

@mortonjt mortonjt commented Jul 8, 2021

This fixes the issue with sparse matching with #290 . We still need to fix travis to get this in.

@mortonjt
Copy link
Collaborator Author

mortonjt commented Jul 8, 2021

I've also updated both matching methods so that the set ops don't add any additional randomness.
Turns out that set ops are inherently unstable, no random seeds can make the set ordering reproducible.
So after taking intersections, these sets are converted to lists and sorted.

@mortonjt mortonjt merged commit 544ef2f into master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant