-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Util #12
Merged
Merged
Util #12
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
362fe9e
ENH: Adding util functions
mortonjt a1b9cef
STY: pep8
mortonjt 2908c93
STY: Flake8 to the rescue
mortonjt e2e2e63
STY: Addressing @antgonza and @josenavas comments
mortonjt d6a037b
STY: pep8 flake8
mortonjt d197605
DOC: Changing method name
mortonjt 2ded931
STY: clean up pep8/flake8
mortonjt a54d051
Merge branch 'master' of https://github.com/biocore/gneiss into util
mortonjt 477d196
DOC: Updating changelog
mortonjt 371cc16
ENH: Adding inplace option
mortonjt 6d70cf9
STY: Code dereplication
mortonjt 9003db8
DOC: cleaning up docstrings
mortonjt b049ced
pep8
mortonjt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
STY: clean up pep8/flake8
- Loading branch information
commit 2ded931959028e69ef3f19e9b30ac6b9fc75c524
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the copy strictly necessary? I'm thinking if it will be okay to just do the renaming inplace - just thinking on the memory footprint of this operations as the tree size increases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copy isn't strictly necessary. But it is certainly useful. Just added an
inplace
parameter here.It'll be tricky to have this functionality in the other modules, mainly because pandas and skbio don't make filter and
shear
operations in place (as far as I'm aware). If you think this is necessary, we can create an issue for this, so that this PR can proceed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I follow with the second part of your comment. With the
inplace
parameter my comment is resolved.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet. Then that settles it :)
On Mon, Jul 25, 2016 at 4:56 PM, Jose Navas notifications@github.com
wrote: