Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take column names from all metadata not just first entry #881

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

asafpr
Copy link
Contributor

@asafpr asafpr commented Sep 20, 2022

When converting observation metadata to dataframe the column names were taken from the first row. When the first row had missing values (i.e. incomplete taxonomic assignment) then the number of columns would not match the column headers. I changed it to take the maximal list of column names from all rows.

@wasade
Copy link
Member

wasade commented Oct 14, 2022

Hi @asafpr, sorry for the delay on this -- reviewing now

@wasade
Copy link
Member

wasade commented Dec 9, 2022

Thanks!!!

@wasade wasade merged commit af56982 into biocore:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants