Normalize metadata on parse #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thermokarst
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
Tested locally (in situ on busywork, more specifically), can confirm that this addresses the failures in https://busywork.qiime2.org/teams/main/pipelines/master-distribution/jobs/unit-test-q2-deblur/builds/118, on linux-64 and darwin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During QIIME 2 2020.11 environment testing, @thermokarst observed an unusual test failure in qiime2/q2-deblur where a parsed BIOM-Format v2.1.0 table contained ASCII strings rather than UTF-8 strings. This appears to be due to a possible variation in the underlying hdf5 or h5py dependency. The PR here is defensive, where on parse it casts bytes -> UTF8. Note that variable length lists (e.g., taxonomy) already decode to UTF-8.