-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue639 #650
Issue639 #650
Conversation
👍 |
self.assertIsNot(obs, exp) | ||
self.assertEqual(obs, exp) | ||
|
||
def head_bounded(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be test_head_bounded
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hah, yes. good catch
I think I commented this in the issue but, given the inherent sparsity of the data, it will be possible that showing the first (n, m) rows/cols of data will not fulfill the goal of the command, which was to see a few non-zero values. Probably a parameter that, if passed, searches for the first non-zero value and shows the (n, m) table starting at such value might help? e.g. if the first non-zero value is at (1, 20) it shows (1, 20) to (1+n, 20+m) |
@josenavas, I think that's a good suggestion, but let's make that change after this one goes in. This is lower priority for 2.1.5 (see the milestones for the blocking issues) so I don't want us to get bogged down in this today as we're going for the (maybe overly optimistic) goal of release today. |
That makes sense - thanks for the clarification @gregcaporaso !! |
Agree |
Partially addresses #639, but is dependent on #631 for a CLI