Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update_ids can silently truncate IDs #957

Closed
wasade opened this issue Apr 22, 2024 · 0 comments
Closed

update_ids can silently truncate IDs #957

wasade opened this issue Apr 22, 2024 · 0 comments

Comments

@wasade
Copy link
Member

wasade commented Apr 22, 2024

If operating with strict=False, the datatype creation may be set to a value too small if the max length of the values is less than the max length of the current IDs
wasade added a commit to wasade/biom-format that referenced this issue May 2, 2024
@wasade
TST: regression test for issue biocore#957
26251d2
wasade added a commit to wasade/biom-format that referenced this issue May 2, 2024
@wasade
BUG: update_ids data type width was sensitive to strict setting, issue …
9f3ee14 
…biocore#957
wasade added a commit to wasade/biom-format that referenced this issue May 2, 2024
@wasade
DOC: mention of issue biocore#957
fc8a0bf
wasade added a commit that referenced this issue May 7, 2024
@wasade
Issue 957 (#963)
0cb7fcc 
* TST: regression test for issue #957

* BUG: update_ids data type width was sensitive to strict setting, issue #957

* DOC: mention of issue #957
@wasade wasade closed this as completed May 7, 2024
@wasade wasade mentioned this issue May 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wasade