Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance issue in Table.collapse #761

Closed
wasade opened this issue Oct 16, 2017 · 1 comment
Closed

Performance issue in Table.collapse #761

wasade opened this issue Oct 16, 2017 · 1 comment

Comments

@wasade
Copy link
Member

wasade commented Oct 16, 2017

By default, Table.collapse uses operator.add which was previously observed to be a performance bottleneck with Table.merge. It is likely that switching the default to use +, or Table.sum, will afford an easy performance benefit with minimal to no loss of functionality.
@wasade
Copy link
Member Author

wasade commented Oct 17, 2017

This was previously noted in qiime2/q2-taxa#54

wasade added a commit to wasade/biom-format that referenced this issue Sep 11, 2018
@wasade
Bette changelog message, fixes biocore#761
7f51ea6
@wasade wasade mentioned this issue Dec 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wasade