Skip to content

Commit

Permalink
Addressing @antgonza's comments
Browse files Browse the repository at this point in the history
  • Loading branch information
wasade committed Nov 5, 2016
1 parent 7a4cb03 commit b4b0d1d
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions biom/table.py
Original file line number Diff line number Diff line change
Expand Up @@ -2966,8 +2966,6 @@ def concat(self, others, axis='sample'):
O5 0.0 0.0 0.0 0.0 0.0 0.0 15.0 16.0 17.0
"""
# should this be a staticmethod?

# we grow along the opposite axis
invaxis = self._invert_axis(axis)
if axis == 'sample':
Expand Down Expand Up @@ -3039,7 +3037,8 @@ def concat(self, others, axis='sample'):
tmp_ids = list(table.ids(axis=axis))
tmp_md = table.metadata(axis=axis)

# this sucks.
# resolve construction based off axis. This really should be
# pushed to a classmethod.
if axis == 'sample':
tmp_table = self.__class__(tmp_mat, tmp_inv_ids, tmp_ids,
tmp_inv_md, tmp_md)
Expand Down

0 comments on commit b4b0d1d

Please sign in to comment.