Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prophyle: add linux-aarch64 build #47373

Merged
merged 2 commits into from
May 1, 2024
Merged

Conversation

martin-g
Copy link
Contributor

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@martin-g martin-g force-pushed the aarch64-prophyle-2 branch from 981196e to ab82400 Compare April 22, 2024 06:45
@martin-g
Copy link
Contributor Author

The Linux ARM64 build fails with the same problem as:

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g martin-g force-pushed the aarch64-prophyle-2 branch from 80b7c91 to 8036352 Compare April 30, 2024 17:49
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
Copy link
Contributor Author

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 prophyle-0.3.3.2-py310h6cc9453_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
linux-64 prophyle-0.3.3.2-py38h5cf8b27_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
linux-64 prophyle-0.3.3.2-py39h4e691d4_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
osx-64 prophyle-0.3.3.2-py310h4b49385_1.tar.bz2 OSXArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the OSXArtifacts directory: conda install -c ./packages <package name>
osx-64 prophyle-0.3.3.2-py38hf7fe521_1.tar.bz2 OSXArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the OSXArtifacts directory: conda install -c ./packages <package name>
osx-64 prophyle-0.3.3.2-py39hd999155_1.tar.bz2 OSXArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the OSXArtifacts directory: conda install -c ./packages <package name>
linux-aarch64 prophyle-0.3.3.2-py310heba8b3b_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/f8f34f8b-d875-4ffa-812b-37901cb684ec/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 prophyle-0.3.3.2-py38h4b64ade_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/f8f34f8b-d875-4ffa-812b-37901cb684ec/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 prophyle-0.3.3.2-py39h73eeb99_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/f8f34f8b-d875-4ffa-812b-37901cb684ec/artifacts/0/tmp/artifacts/packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
prophyle 0.3.3.2--py310h6cc9453_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/prophyle:0.3.3.2--py310h6cc9453_1.tar.gz | docker load
prophyle 0.3.3.2--py38h5cf8b27_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/prophyle:0.3.3.2--py38h5cf8b27_1.tar.gz | docker load
prophyle 0.3.3.2--py39h4e691d4_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/prophyle:0.3.3.2--py39h4e691d4_1.tar.gz | docker load

@martin-g
Copy link
Contributor Author

martin-g commented May 1, 2024

After installing ete3==3.1.3 (with pyqt 5.x) all looks good:

mgrigorov in 🌐 euler-arm-22 in /tmp/prophyle via 🅒 test123 took 39s 
❯ prophyle                                                                                                                                                                                                 (test123) 

Program: prophyle (phylogeny-based metagenomic classification)
Version: 0.3.3.2
Authors: Karel Brinda, Kamil Salikhov, Simone Pignotti, Gregory Kucherov
Contact: kbrinda@hsph.harvard.edu

Usage:   prophyle <command> [options]
options:
Command:
  
    download     download a genomic database
    index        build index
    classify     classify reads
    analyze      analyze results (experimental)
    footprint    estimate memory footprint

    compress     compress a ProPhyle index
    decompress   decompress a compressed ProPhyle index
    compile      compile auxiliary ProPhyle programs

LGTM!

@martin-g
Copy link
Contributor Author

martin-g commented May 1, 2024

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label May 1, 2024
@rpetit3 rpetit3 merged commit 8adb61f into bioconda:master May 1, 2024
6 checks passed
@martin-g martin-g deleted the aarch64-prophyle-2 branch May 1, 2024 17:32
daler pushed a commit that referenced this pull request May 14, 2024
* prophyle: add linux-aarch64 build

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>

* Bump the build number

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>

---------

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to adding linux-aarch64 support help wanted please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants