Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bioconductor-deseq2 adding new platform #46594

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pabloaledo
Copy link
Contributor

update bioconductor-deseq2 adding new platform

Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@martin-g
Copy link
Contributor

All bioconductor-** recipes fail on Linux ARM64 with the reason explained at #46177

@pabloaledo
Copy link
Contributor Author

Do we need to do anything from the recipe point of view?.
Will the action re-trigger automatically when the issue is fixed?.
If not, how can we continue when #46177 is fixed?

@martin-g
Copy link
Contributor

Will the action re-trigger automatically when the issue is fixed?

No. You (or anyone with the needed permissions) will need to re-trigger it again once the issue is solved.
I'm just linking the issues so we can easily track which PRs depend on the issue and to ping them later.

@rpetit3 rpetit3 added the aarch64 Related to adding linux-aarch64 support label Mar 20, 2024
@pabloaledo
Copy link
Contributor Author

Will the action re-trigger automatically when the issue is fixed?

No. You (or anyone with the needed permissions) will need to re-trigger it again once the issue is solved. I'm just linking the issues so we can easily track which PRs depend on the issue and to ping them later.

Hey @martin-g , we are thinking about giving this one and some other PRs that are pending on #46177 another try. Do you think it's ready?. Can we re-trigger them and continue?.

Thanks.

@martin-g
Copy link
Contributor

Hi! Unfortunately the other issue is still valid!
There were some discussions about it at bioconda/bioconda-containers#77.
Anything that depends on font-ttf-ubuntu (even transitively) package fails during mulled-build due to permissions issues - one Docker container creates a shared folder that is owner by the root user and then another Docker container tries to read this folder with a non-root user.
And it happens only when font-ttf-ubuntu is involved because of some weird licences/ folder appearing from nowhere ...

We need help from someone who understands better the mulled build setup.

@martin-g
Copy link
Contributor

Please rebase to re-test the PR!

@martin-g
Copy link
Contributor

martin-g commented May 3, 2024

@martin-g martin-g force-pushed the bioconductor-deseq2 branch from 32e917d to 1a8b2e1 Compare May 6, 2024 06:50
martin-g added a commit to martin-g/bioconda-recipes that referenced this pull request May 6, 2024
Needed by bioconda#46594

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
bgruening pushed a commit that referenced this pull request May 6, 2024
* bioconductor-apeglm: add linux-aarch64 build

Needed by #46594

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>

* bioconductor-genomicranges: add linux-aarch64 build

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>

---------

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g martin-g force-pushed the bioconductor-deseq2 branch from 1a8b2e1 to c920056 Compare May 6, 2024 18:49
@martin-g martin-g force-pushed the bioconductor-deseq2 branch from c920056 to 6d7eb19 Compare May 7, 2024 07:07
daler pushed a commit that referenced this pull request May 14, 2024
* bioconductor-apeglm: add linux-aarch64 build

Needed by #46594

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>

* bioconductor-genomicranges: add linux-aarch64 build

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>

---------

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to adding linux-aarch64 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants