-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update unifrac-binaries recipe, remove hdf5 dependency #38396
Conversation
@BiocondaBot please fetch artifacts |
Package(s) built on Azure are ready for inspection:
You may also use
Docker image(s) built (images are in the LinuxArtifacts zip file above):
|
@BiocondaBot please add label |
Tested the artifacts locally, and they look good |
The readme has mentioned HDF5 everywhere: https://github.com/biocore/unifrac-binaries#install-native Is this really how it should be done? |
hdf5 is needed during compile, but not at runtime. PS: We could possibly improve the README, yes. |
@sfiligoi, but that wasn't previously the case correct? It looks like that was added/fixed in biocore/unifrac-binaries#15, which is included in this latest release. (Thanks for updating unifrac by the way! We had just tracked down some incompatibilities between h5py/scikit-bio and unifrac-binaries in our latest pre-release envs, and these changes should fix that) |
@ebolyen Yes, unifrac-binaries 1.1.x needed hdf5 at runtime. Note: The hdf5 dependency in 1.1.x was actually a Makefile bug; the dependency was never supposed to be there. |
Anything we can do to help get this merged? (I realize this is isn't ideal, but we're waiting on these changes so that we can get the latest scikit-bio in the next QIIME 2 release.) |
We've tested this locally as well now and can confirm that the static linking appears to be working. We succesfully installed these built packages alongside a source install of The tests from our downstream packages ( |
(I'm not really sure why bioconda built with |
@bgruening Anything blocking this revision? |
Is anyone on the Bioconda team available to review this? Thanks! |
@rpetit3 Any chance you can look at this? |
@matthdsm Any chance you can review this? |
@BiocondaBot please merge |
I will attempt to upload artifacts and merge this PR. This may take some time, please have patience. |
Merge PR bioconda#38396, commits were: * Remove hdf5 dependency at runtime
HDF5 is fully statically linked in unifrac-binaries 1.2.
Remove runtime dependencies from the recipe.
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
@BiocondaBot please add label
command.@bioconda/core
in a comment.Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
For members of the Bioconda project, the following command is also available:
@BiocondaBot please merge
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.
Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.