Don't add 'object' type when generating sum schema with allOf/oneOf #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating schema for some sum types the
type
field is set asobject
. But that seems to be incorrect. E.g.will have schema
However, encoding of the Foo is clearly not an object.
This also confuses SwaggerUI.
Schema is valid
But generated example is not
If one removes
type
field example becomes validUnrelated change, but looks like there was a redundant dependency on
network
package. Few types from it were imported, but neither used nor re-exported.