Feature/BBL-440 | ci improvement #1
Conversation
| - slack/notify: | ||
| event: fail | ||
| mentions: '@leverage-support' | ||
| template: basic_fail_1 |
There was a problem hiding this comment.
@exequielrafaela Just curious, are these templates defined in CircleCI's project configuration?
There was a problem hiding this comment.
@diego-ojeda-binbash OJ you can find them here -> https://github.com/CircleCI-Public/slack-orb/tree/master/src/message_templates
.circleci/config.yml
Outdated
| sudo mv ./terraform-docs /usr/local/bin/terraform-docs | ||
|
|
||
| - run: | ||
| name: test1-terraform-format-and-docs-mod-a |
There was a problem hiding this comment.
@exequielrafaela Just a couple of concerns regarding the names of these steps:
1- I would suggest not to use test1, test2, and so on. Perhaps just test is good enough to indicate the general purpose of the step.
2- I would also suggest not to use mod-a, mod-b, and so on. I think it would be more helpful to use either the name of the module under test or part of it, so that when we receive notifications we can tell which tests of which module failed.
There was a problem hiding this comment.
@diego-ojeda-binbash OJ agreed ✅ Thanks for your feedback :)
What?
Commits on Nov 13, 2020
Why?
Validation