fix: Add missing Name tag to service security group (terraform-aws-…

…modules#177) * fix: Add missing Name tag in service sg Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com> * chore: Fix up ordering --------- Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com> Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
binbashar · Mar 4, 2024 · b3600de · b3600de
1 parent 62001b5
commit b3600de
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/antonbabenko/pre-commit-terraform
-    rev: v1.83.6
+    rev: v1.88.0
     hooks:
       - id: terraform_fmt
       - id: terraform_wrapper_module_for_each

diff --git a/modules/service/main.tf b/modules/service/main.tf
@@ -1320,7 +1320,11 @@ resource "aws_security_group" "this" {
   description = var.security_group_description
   vpc_id      = data.aws_subnet.this[0].vpc_id
 
-  tags = merge(var.tags, var.security_group_tags)
+  tags = merge(
+    var.tags,
+    { "Name" = local.security_group_name },
+    var.security_group_tags
+  )
 
   lifecycle {
     create_before_destroy = true