Fix: enabling SSM access when a profile is passed #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rm-aws-ec2-basic-layout into feature/fix-ssm-config
|
@joseapeinado The tests passed after the fix => https://app.circleci.com/pipelines/github/binbashar/terraform-aws-ec2-basic-layout/228/workflows/24e86786-6b3b-404a-a498-6069cbf15539/jobs/328 But I don't get why they're failing now. For this iteration I'll move forward and merge this PR and we can give it another try the next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
It fixes the bug #35 while enabling SSM access and passing an
instance_profilevalue.why
When the
instance_profilewas provided andenable_ssm_accesswas set to true, the resourceaws_iam_role_policy_attachment.ec2_ssm_accesstried to attach the managed policyAmazonSSMManagedInstanceCoreto a non existing rolebasic_instance_assume_role, which is only created when theinstance_profileis empty.references