Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add K8S Network Section & Fix some typos #142

Merged
merged 14 commits into from
Feb 8, 2023

Conversation

marianod92
Copy link
Contributor

@marianod92 marianod92 commented Jan 16, 2023

What?

  • Update K8S-EKS with Networking general considerations & examples
  • Add reference to K8s-EKS Networking into main VPC Addressing Doc

Why?

  • To reflect in the documentation the latest updates of the reference architecture

References

@exequielrafaela exequielrafaela requested a review from a team January 17, 2023 18:19
@exequielrafaela exequielrafaela added documentation Improvements or additions to documentation patch labels Jan 17, 2023
@marianod92 marianod92 marked this pull request as ready for review January 19, 2023 19:30
@marianod92 marianod92 requested a review from a team as a code owner January 19, 2023 19:30
Copy link
Member

@exequielrafaela exequielrafaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marianod92 Thank you so much for your outstanding contributions to the binbash Leverage open source project. Your dedication and hard work are greatly appreciated by the entire community. Keep up the great work!

@marianod92
Copy link
Contributor Author

image

@exequielrafaela exequielrafaela requested a review from a team January 30, 2023 21:31
Copy link
Member

@exequielrafaela exequielrafaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marianod92 This PR looks great, thanks for your contribution. I've just requested some minor editions.

I would also like to request the possibility to add at the end of this section 👉🏼 https://leverage.binbash.com.ar/how-it-works/ref-architecture/ref-architecture-eks/ something similar to:

## Read More

!!! info "EKS Reference Architecture Specs" 
    In case you would like to further understand the different tech specs and configs for this Ref Arch you could find some details like at the [Features/Compute/K8s EKS section](../features/compute/k8s-eks/overview)

@marianod92
Copy link
Contributor Author

@marianod92 This PR looks great, thanks for your contribution. I've just requested some minor editions.

I would also like to request the possibility to add at the end of this section 👉🏼 https://leverage.binbash.com.ar/how-it-works/ref-architecture/ref-architecture-eks/ something similar to:

## Read More

!!! info "EKS Reference Architecture Specs" 
    In case you would like to further understand the different tech specs and configs for this Ref Arch you could find some details like at the [Features/Compute/K8s EKS section](../features/compute/k8s-eks/overview)
  • Added Reference:

    image

@exequielrafaela exequielrafaela self-requested a review February 8, 2023 13:49
@marianod92 marianod92 merged commit 8f81ac9 into master Feb 8, 2023
@marianod92 marianod92 deleted the issue185-EKS-Networking-ip-addressing branch February 8, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants