Fix lint issues (#183)

config/api.js

@@ -1,4 +1,4 @@
-module.exports = ({ env }) => ({
+module.exports = (/*{ env }*/) => ({
   responses: {
     // privateAttributes: ['_v', 'id', 'created_at'],
   },

config/cron-tasks.js

@@ -1,5 +1,5 @@
 module.exports = {
-  '0 18 * * 5': async ({strapi}) => {
+  '0 18 * * 5': async (/*{strapi}*/) => {
     // Every Friday at 6pm
     // await deliveryToEmailSubscriptions.send('Binary Coffee Weekly Posts', 7);
     console.log('send weekly email');

config/server.js

@@ -1,4 +1,4 @@
-const cronTasks = require("./cron-tasks");
+// const cronTasks = require('./cron-tasks');
 
 module.exports = ({env}) => ({
   host: env('HOST', '0.0.0.0'),

package.json

@@ -18,17 +18,18 @@
     "moment": "^2.26.0",
     "moment-timezone": "^0.5.31",
     "mysql": "^2.18.1",
-    "pre-push": "^0.1.1",
     "svg-captcha": "^1.4.0"
   },
   "description": "Binary Coffee backend",
   "devDependencies": {
+    "babel-eslint": "^10.1.0",
     "better-sqlite3": "^8.3.0",
     "chai": "^4.2.0",
     "chai-http": "^4.3.0",
     "chai-spies": "^1.0.0",
     "mocha": "^10.2.0",
-    "nyc": "^15.0.0"
+    "nyc": "^15.0.0",
+    "pre-push": "^0.1.1"
   },
   "engines": {
     "node": ">=14.0.0",
@@ -50,7 +51,7 @@
     "test": "NODE_ENV=test nyc --reporter=lcov --reporter=html mocha --ui bdd tests/bootstrap.js tests/integration/**/*.js tests/unit/**/*.js",
     "lint": "eslint .",
     "lint:fix": "eslint . --fix",
-    "check": "npm run test:cov && npm run lint && npm run build"
+    "check": "npm test && npm run lint && npm run build"
   },
   "strapi": {
     "uuid": "b8aa7baf-d6dc-4c50-93d4-7739bc88c3fd"

src/api/comment/config/schema.graphql.js

@@ -14,7 +14,7 @@ module.exports = (strapi) => {
 
           args: { limit: 'Int' },
 
-          resolve(parent, args, context) {
+          resolve(parent, args) {
             const { limit } = args;
             return strapi.service('api::comment.comment').recentComments(limit);
           }

src/api/comment/routes/comment-extra.js

@@ -1,9 +1,9 @@
 module.exports = {
   routes: [
     {
-      method: "GET",
-      path: "/recentComments",
-      handler: "comment.recentComments",
+      method: 'GET',
+      path: '/recentComments',
+      handler: 'comment.recentComments',
     }
   ]
-}
+};

src/api/image/controllers/image.js

@@ -2,7 +2,7 @@
 
 const {createCoreController} = require('@strapi/strapi').factories;
 
-module.exports = createCoreController('api::image.image', ({strapi}) => ({
+module.exports = createCoreController('api::image.image', () => ({
   findExtra(ctx) {
     return super.find(ctx);
   }

src/api/podcast/config/schema.graphql.js

@@ -1,6 +1,3 @@
-const canRemove = require("../../comment/policies/canRemove");
-const canComment = require("../../comment/policies/canComment");
-const canUpdateComment = require("../../comment/policies/canUpdateComment");
 module.exports = (strapi) => {
   const extensionService = strapi.plugin('graphql').service('extension');
 
@@ -12,7 +9,7 @@ module.exports = (strapi) => {
           type: nexus.nonNull('Podcast'),
           args: { identifier: nexus.nonNull('String') },
 
-          resolve(parent, args, context) {
+          resolve(parent, args) {
             const {identifier} = args;
             return strapi.service('api::podcast.podcast').findOneByIdentifier(identifier);
           }

src/api/podcast/routes/podcast-extra.js

@@ -1,9 +1,9 @@
 module.exports = {
   routes: [
     {
-      method: "GET",
-      path: "/podcastByIdentifier",
-      handler: "podcast.podcastByIdentifier",
+      method: 'GET',
+      path: '/podcastByIdentifier',
+      handler: 'podcast.podcastByIdentifier',
     }
   ]
-}
+};

src/api/post/config/schema.graphql.js

@@ -1,7 +1,7 @@
 const canCreatePost = require('../policies/canCreatePost');
 const canModifyPost = require('../policies/canModifyPost');
 const canPublishPost = require('../policies/canPublishPost');
-const tmp = require('../../../policies/validateFindMethod');
+const validateFindMethod = require('../policies/validateFindMethod');
 
 module.exports = (strapi) => {
   const extensionService = strapi.plugin('graphql').service('extension');
@@ -40,7 +40,7 @@ module.exports = (strapi) => {
         t.field('similarPosts', {
           type: nexus.nonNull(nexus.list('Post')),
           args: {id: nexus.nonNull('ID'), limit: 'Int'},
-          resolve(parent, args, context) {
+          resolve(parent, args) {
             const {id, limit} = args;
             return strapi.service('api::post.post').findSimilarPosts(id, limit);
           }
@@ -59,7 +59,7 @@ module.exports = (strapi) => {
         }
       },
       'Query.posts': {
-        policies: ['global::validateFindMethod']
+        policies: [validateFindMethod]
       },
       'Mutation.createPost': {
         policies: [canPublishPost, canCreatePost]

src/api/post/controllers/post.js

@@ -2,7 +2,7 @@
 
 const {createCoreController} = require('@strapi/strapi').factories;
 
-const {j2xParser: Parser} = require("fast-xml-parser");
+const {j2xParser: Parser} = require('fast-xml-parser');
 
 module.exports = createCoreController('api::post.post', ({strapi}) => ({
   async find(ctx) {

src/policies/validateFindMethod.js → src/api/post/policies/validateFindMethod.js

@@ -1,7 +1,7 @@
 'use strict';
 
-module.exports = async (ctx, config, {strapi}) => {
-  const {filters = {}, pagination, sort, publicationState} = ctx.args;
+module.exports = async (ctx) => {
+  const {filters = {}, publicationState} = ctx.args;
   if (publicationState === 'preview') {
     if (ctx.state.user === undefined) {
       filters.publishedAt = {lte: new Date()};

src/api/post/routes/post-extra.js

@@ -1,34 +1,34 @@
 module.exports = {
   routes: [
     {
-      method: "GET",
-      path: "/post-body-by-name/:name/download.md",
-      handler: "post.getPostBodyByName",
+      method: 'GET',
+      path: '/post-body-by-name/:name/download.md',
+      handler: 'post.getPostBodyByName',
     },
     {
-      method: "GET",
-      path: "/posts/feed/:username/:format",
-      handler: "post.feedByUsername",
+      method: 'GET',
+      path: '/posts/feed/:username/:format',
+      handler: 'post.feedByUsername',
     },
     {
-      method: "GET",
-      path: "/posts/feed/:format",
-      handler: "post.feed",
+      method: 'GET',
+      path: '/posts/feed/:format',
+      handler: 'post.feed',
     },
     {
-      method: "GET",
-      path: "/sitemap",
-      handler: "post.sitemap"
+      method: 'GET',
+      path: '/sitemap',
+      handler: 'post.sitemap'
     },
     {
-      method: "GET",
-      path: "/similarPosts",
-      handler: "post.findSimilarPosts"
+      method: 'GET',
+      path: '/similarPosts',
+      handler: 'post.findSimilarPosts'
     },
     {
-      method: "GET",
-      path: "/findOneByName",
-      handler: "post.findOneByName"
+      method: 'GET',
+      path: '/findOneByName',
+      handler: 'post.findOneByName'
     }
   ]
-}
+};

src/api/subscription/services/subscription.js

@@ -2,7 +2,7 @@
 
 const { createCoreService } = require('@strapi/strapi').factories;
 
-module.exports = createCoreService('api::subscription.subscription', ({strapi}) => ({
+module.exports = createCoreService('api::subscription.subscription', () => ({
   generateToken (size = 12) {
     const characters = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_';
     return new Array(size)

src/extensions/users-permissions/config/schema.graphql.js

@@ -1,6 +1,3 @@
-const canRemove = require("../../../api/comment/policies/canRemove");
-const canComment = require("../../../api/comment/policies/canComment");
-const canUpdateComment = require("../../../api/comment/policies/canUpdateComment");
 module.exports = (strapi) => {
   const extensionService = strapi.plugin('graphql').service('extension');
 
@@ -93,7 +90,7 @@ module.exports = (strapi) => {
             pagination: 'PaginationArg',
             sort: nexus.list('String')
           },
-          resolve(parent, args, context) {
+          resolve(parent, args) {
             return strapi.service('plugin::users-permissions.extra').users(args);
           }
         });

src/extensions/users-permissions/controllers/user.js

@@ -1,7 +1,8 @@
 'use strict';
 
 module.exports = (controller) => {
-  controller.users = async function(ctx, next, {populate} = {}) {
+  controller.users = async function() {
+    // toDo 01.05.23, guille,
     return [];
   };
 

src/extensions/users-permissions/services/user.js

@@ -3,7 +3,7 @@ function buildSortObject(sort) {
     sort = [];
   }
   return sort.reduce((p, v) => {
-    const vs = v.split(':')
+    const vs = v.split(':');
     if (vs.length === 2) {
       p[vs[0]] = vs[1];
     }

src/functions/delivery.to.email.subscriptions.js

@@ -33,7 +33,7 @@ async function getHtmlWithPosts(posts) {
       './public/posts-for-subscriptions-template.html',
       data,
       options,
-      (err, str) =>  err ? reject(err) :resolve(str))
+      (err, str) =>  err ? reject(err) :resolve(str));
   });
 }
 

src/policies/disable.js

@@ -0,0 +1,5 @@
+'use strict';
+
+module.exports = async () => {
+  return false;
+};

tests/integration/post/limit-published-posts.js

@@ -5,7 +5,7 @@ const randomName = require('../../helpers/random-name');
 const createUser = require('../../helpers/create-user');
 const generateJwt = require('../../helpers/generate-jwt-by-user');
 const createPostRequest = require('../../helpers/create-post-request');
-const createPost = require("../../helpers/create-post");
+const createPost = require('../../helpers/create-post');
 
 chai.use(chaiHttp);
 

tests/integration/upload/remove-files.js

@@ -5,7 +5,6 @@ const spies = require('chai-spies');
 const createUser = require('../../helpers/create-user');
 const generateJwt = require('../../helpers/generate-jwt-by-user');
 const createFile = require('../../helpers/create-file');
-const randomName = require("../../helpers/random-name");
 
 chai.use(chaiHttp);
 chai.use(spies);
@@ -67,7 +66,7 @@ describe('Remove file/images INTEGRATION', () => {
 
     const {file, image} = await createFile(strapi, staffUser);
 
-    const res = await new Promise(resolve => {
+    const res = await new Promise((resolve, reject) => {
       chai.request(strapi.server.httpServer)
         .delete(`/api/upload/files/${file.id}`)
         .set('Authorization', `Bearer ${jwt}`)
@@ -88,7 +87,7 @@ describe('Remove file/images INTEGRATION', () => {
 
     const {file, image} = await createFile(strapi, authUser);
 
-    const res = await new Promise(resolve => {
+    const res = await new Promise((resolve, reject) => {
       chai.request(strapi.server.httpServer)
         .delete(`/api/upload/files/${file.id}`)
         .set('Authorization', `Bearer ${jwt}`)
@@ -109,7 +108,7 @@ describe('Remove file/images INTEGRATION', () => {
 
     const {file, image} = await createFile(strapi, staffUser);
 
-    const res = await new Promise(resolve => {
+    const res = await new Promise((resolve, reject) => {
       chai.request(strapi.server.httpServer)
         .delete(`/api/upload/files/${file.id}`)
         .set('Authorization', `Bearer ${jwt}`)
@@ -128,7 +127,7 @@ describe('Remove file/images INTEGRATION', () => {
   it('should not be able to remove the file (public)', async () => {
     const {file, image} = await createFile(strapi, authUser);
 
-    const res = await new Promise(resolve => {
+    const res = await new Promise((resolve, reject) => {
       chai.request(strapi.server.httpServer)
         .delete(`/api/upload/files/${file.id}`)
         .end((err, res) => err ? reject(err) : resolve(res));

tests/integration/upload/remove-image.js

@@ -41,7 +41,7 @@ describe('Remove images INTEGRATION', () => {
         return Promise.resolve();
       }),
       delete: chai.spy(() => {
-        Promise.resolve()
+        Promise.resolve();
       }),
       checkFileSize: () => Promise.resolve()
     };
@@ -75,7 +75,7 @@ describe('Remove images INTEGRATION', () => {
     let img = await strapi.query('api::image.image').findOne({where: {id: fileUpload.related[0].id}});
     expect(img).not.null;
 
-    const res2 = await new Promise((resolve, reject) => {
+    await new Promise((resolve, reject) => {
       chai.request(strapi.server.httpServer)
         .post('/graphql')
         .set('Authorization', `Bearer ${jwt}`)