Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

adds new filter type values #194

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

igorustinov
Copy link

adds new enum values to FilterType as per Binance changelog
https://github.com/binance-exchange/binance-official-api-docs/blob/master/CHANGELOG.md from
018-11-13
New filters: PERCENT_PRICE, MARKET_LOT_SIZE, MAX_NUM_ICEBERG_ORDERS.

Fixes
#193

@brintal
Copy link

brintal commented Dec 4, 2018

@joaopsilva Please merge this ASAP. Current build breaks without these changes cause Binance started to send the new filter types in the response since today or yesterday.

@IAmNigh
Copy link

IAmNigh commented Dec 4, 2018

in FilterType.java change to:

public enum FilterType {
// Symbol
PRICE_FILTER,
PERCENT_PRICE,
LOT_SIZE,
MARKET_LOT_SIZE,
MIN_NOTIONAL,
MAX_NUM_ORDERS,
MAX_ALGO_ORDERS,
MAX_NUM_ALGO_ORDERS,
ICEBERG_PARTS,
MAX_NUM_ICEBERG_ORDERS,

// Exchange
EXCHANGE_MAX_NUM_ORDERS,
EXCHANGE_MAX_ALGO_ORDERS
}

Copy link
Member

@joaopsilva joaopsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@joaopsilva joaopsilva merged commit 0a5624b into binance-exchange:master Dec 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants