Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

custom dispatcher for sharedClient to allow for more parallel requests #190

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

brintal
Copy link

@brintal brintal commented Nov 14, 2018

Since commit bed23c0
there is only one application wide shared HTTP client instance.

Because of the fact that no custom dispatcher for this client is configured, the following default request limits apply to the whole application:

  private int maxRequests = 64;
  private int maxRequestsPerHost = 5;

These limits are far to little when running a bigger trading application which retrieves updates for many symbols in parallel.

To solve this issue I introduced a customized dispatcher with maxRequests and maxRequestsPerHost of 500.

Copy link
Member

@joaopsilva joaopsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@joaopsilva joaopsilva merged commit d74588f into binance-exchange:master Dec 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants