Skip to content

Commit

Permalink
Comment and name fixes to unit test
Browse files Browse the repository at this point in the history
* Renamed the test script to reflect that it tests all workbook
  bookview attributes, not just the 'showSheetTabs' attribute.
* Rewrote the comment for the test case to indicate that it
  tests all workbook bookvview attributes.
  • Loading branch information
billblume committed Jun 12, 2018
1 parent 223a368 commit 90143d0
Showing 1 changed file with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
use PhpOffice\PhpSpreadsheet\Spreadsheet;
use PHPUnit\Framework\TestCase;

class HiddenTabsTest extends TestCase
class WorkbookViewAttrsTest extends TestCase
{
/**
* Copy of PhpOffice\PhpSpreadsheet\Writer\Xlsx\Workbook::$bookViewAttributes
Expand All @@ -27,10 +27,13 @@ class HiddenTabsTest extends TestCase
];

/**
* Test that the worksheet tabs remain hidden when reading and writing a XLSX document
* with hidden worksheets tabs.
* Test that workbook bookview attributes such as 'showSheetTabs',
* (the attribute controlling worksheet tabs visibility,)
* are preserved when xlsx documents are read and written.
*
* @see https://github.com/PHPOffice/PhpSpreadsheet/issues/523
*/
public function testUpdateWithHiddenTabs()
public function testPreserveWorkbookViewAttributes()
{
// Create a dummy workbook with two worksheets
$workbook = new Spreadsheet();
Expand Down

0 comments on commit 90143d0

Please sign in to comment.