Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@cronner-period does not actually accept all possible values for strtotime() #38

Closed
lucien144 opened this issue Mar 4, 2015 · 3 comments
Assignees
Labels

Comments

@lucien144
Copy link

This https://github.com/stekycz/Cronner/blob/master/Cronner/Tasks/Parser.php#L49 causes errors for strtotime acceptable values that does not start with + sign like "first day of this month" and so on...

@stekycz stekycz added the bug label Mar 4, 2015
@stekycz stekycz self-assigned this Mar 4, 2015
@stekycz
Copy link
Collaborator

stekycz commented Mar 4, 2015

Thank you for report! What would be a solution from your point of view? I think I should update documentation only because period needs something with "+" sign.

@lucien144
Copy link
Author

Yes, I'd update documentation and maybe the error message as well. Says that the period is not valid if actually is, is confusing :)

@stekycz
Copy link
Collaborator

stekycz commented Mar 4, 2015

Consider it as solved :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants