Fix URL Params Appending on Boost #1811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhaggi
reviewed
Oct 13, 2023
| @@ -3102,7 +3102,7 @@ return (function () { | |||
|
|
|||
| // behavior of anchors w/ empty href is to use the current URL | |||
| if (path == null || path === "") { | |||
| path = getDocument().location.href; | |||
| path = getDocument().location.href.split('?')[0]; | |||
There was a problem hiding this comment.
As the above comment indicates, this is also applied to anchors with an empty href attribute and that change would be a change in behavior. Not sure if we should fix it here or better move it to
Line 1372 in 7274454
|
I've just started looking into possibly using HTMX and noticed this behavior in my trials. It would be really great to get this or another fix merged! |
|
We can't merge this into the core right now because we are going to refactor this section of it. This is also a big change—would love to see this as an extension first, and we'd be happy to link to it. It's not impossible this could be in the core eventually. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1788.
The change simply takes the URL part without any query params when AJAX request is issued on boosted element.
In case of anchor tags, the href value simply provides the requested URL but in case of forms, the location object is used to get the current href value.
Should this change include a test?
If yes then can somebody help me with that?