-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hard-coded sequence utils with an Alphabet model #410
Comments
I am interested in picking up this issue. I was thinking of creating an abstract class and extending it with appropriate methods/functions for DNA and RNA sequence and then adding IUPAC codes. Does this approach address this issue? It would also mean changing some code in /adam-core/src/main/scala/org/bdgenomics/adam/models/Gene.scala |
You're right, BioJava is LGPL and unfortunately is not explicit as to which version is in use. I tried to add "either version XXX of the License, or (at your option) any later version" language at some point but was unsuccessful. I don't understand though, what the conflict with packaging? Would LGPL version 3 or later be compatible with packaging under Apache 2? |
Has anyone taken a look at https://github.com/bioscala/bioscala/tree/master/src/main/scala/bio/sequence ? |
@Agent007 nice! Thanks for the heads up there; I wasn't aware of that, but it's definitely worth a look. |
…cs#410 removed the SequenceUtils class and updated all references. ran mvn verify and all tests pass. ran ./scripts/format-source make changes as suggested in the pull request: 1. unknown characters should throw illegalArgumentException instead of keyNotFound 2. case-insensitive changed to mean that it will map both lower and upper case characters to the same symbol instead of mapping lower to lower and upper to upper clean up import squashed commits
removed the SequenceUtils class and updated all references. ran mvn verify and all tests pass. ran ./scripts/format-source make changes as suggested in the pull request: 1. unknown characters should throw illegalArgumentException instead of keyNotFound 2. case-insensitive changed to mean that it will map both lower and upper case characters to the same symbol instead of mapping lower to lower and upper to upper clean up import squashed commits
Closed by #653. |
As part of the work on Gene models, we introduced the SequenceUtils object (in adam.utils), which is just a hacky container for some simple "complement" operations on DNA sequences themselves.
This should be replaced by an actual Alphabet model, with support for ambiguity codes, different alphabets, etc.
The text was updated successfully, but these errors were encountered: