Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up if clauses in Transform #1053

Closed
fnothaft opened this issue Jun 17, 2016 · 0 comments
Closed

Clean up if clauses in Transform #1053

fnothaft opened this issue Jun 17, 2016 · 0 comments
Labels
documentation enhancement
Milestone
0.20.0

Comments

@fnothaft
Copy link
Member

org.bdgenomics.adam.cli.Transform has a ton of if clauses that allow us to treat the Transform class essentially as a one-stop-shop for all your Read Transforming Needs™.

However, as has been rightly pointed out, this is a mess to read and follow. As such, we should clean up the tangled web of transforms in Transform.
@fnothaft fnothaft mentioned this issue Jun 17, 2016
Closed
@heuermh heuermh mentioned this issue Jun 27, 2016
Closed
61 tasks
@fnothaft fnothaft mentioned this issue Jul 18, 2016
Merged
@heuermh heuermh modified the milestone: 0.20.0 Jul 18, 2016
fnothaft added a commit to fnothaft/adam that referenced this issue Jul 19, 2016
@fnothaft
[ADAM-1053] Clean up if-clauses in Transform CLI.
c251f79 
Moves all if clauses into `maybeX` methods. Resolves bigdatagenomics#1053.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
0.20.0
Development

No branches or pull requests
2 participants
@heuermh @fnothaft