STENCIL-3243 run the theme bundling script (webpack) in a different process #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocess (fork) & fix a bunch of tests
|
If this prevents Webpack from picking up JSPM's polyfill of |
|
That is exactly what is doing @dstaley. We read your article, and we are in the process of upgrading Cornerstone to use Webpack2. So we thank you. |
mjschock
reviewed
Mar 17, 2017
| @@ -34,6 +34,7 @@ | |||
| "accept-language-parser": "^1.0.2", | |||
| "archiver": "^0.14.4", | |||
| "async": "^1.3.0", | |||
| "babel-eslint": "^7.1.1", | |||
There was a problem hiding this comment.
thank you! this gets the build working now, with the babel-eslint parser
mjschock
reviewed
Mar 17, 2017
| } | ||
| }); | ||
|
|
||
| // process.send('ready'); |
|
LGTM; 👍 and i confirm that it works with the webpack 2 changes to Cornerstone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STENCIL-3243
Run the theme bundling script (webpack) in a different process (fork)
Webpack was run from the cli using a
require()call to a file in the theme directory. This makes webpack to use dependencies fromstencil-cliinstead of only using dependencies from the theme itselfThis requires a change in Cornerstone
stencil.conf.jsformat, but is written to be backwards compatible.Instead of
requireing the file directly fromstencil-cli, we are now usingchild_process.fork()and communicating with the process over an IPC communication channel@bigcommerce/stencil-team