Stencil 3250 - Webpack 2 w/ Code Splitting, Tree Shaking #964
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| /assets/js/bundle.js | ||
| /assets/dist | ||
| stencil.conf.js | ||
| webpack.conf.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| { | ||
| "parser": "babel-eslint", | ||
| "rules": { | ||
| "indent": [ | ||
| 2, | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| > 1% | ||
| last 2 versions | ||
| Firefox ESR |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,73 @@ | ||
| var CleanWebpackPlugin = require('clean-webpack-plugin'), | ||
| config = require('./config.json'), | ||
| LodashModuleReplacementPlugin = require('lodash-webpack-plugin'), | ||
| path = require('path'), | ||
| webpack = require('webpack'); | ||
|
|
||
| module.exports = { | ||
| bail: true, | ||
| context: __dirname, | ||
| devtool: 'source-map', | ||
| entry: { | ||
| main: './assets/js/app.js', | ||
| }, | ||
| module: { | ||
| rules: [ | ||
| { | ||
| test: /\.js$/, | ||
| include: /(assets\/js|assets\\js|stencil-utils)/, | ||
| use: { | ||
| loader: 'babel-loader', | ||
|
There was a problem hiding this comment. |
||
| options: { | ||
| cacheDirectory: true, | ||
| compact: true, | ||
| minified: true, | ||
| plugins: [ | ||
| 'dynamic-import-webpack', // Needed for dynamic imports. | ||
| 'lodash', // Automagically tree-shakes lodash. | ||
| 'transform-regenerator', // Transforms async and generator functions. | ||
| ], | ||
| presets: [ | ||
| ['env', { | ||
| loose: true, // Enable "loose" transformations for any plugins in this preset that allow them. | ||
| modules: false, // Don't transform modules; needed for tree-shaking. | ||
| useBuiltIns: true, // Tree-shake babel-polyfill. | ||
| }], | ||
| ], | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| }, | ||
| output: { | ||
| chunkFilename: 'theme-bundle.chunk.[name].js', | ||
| filename: 'theme-bundle.[name].js', | ||
| path: path.resolve(__dirname, "assets/dist"), | ||
| }, | ||
| plugins: [ | ||
| new CleanWebpackPlugin(['assets/dist'], { | ||
| verbose: true, | ||
| watch: false, | ||
| }), | ||
| new webpack.LoaderOptionsPlugin({ | ||
| minimize: true, | ||
| }), | ||
| new LodashModuleReplacementPlugin, // Complements 'babel-plugin-lodash by shrinking it's cherry-picked builds further. | ||
| new webpack.ProvidePlugin({ | ||
| $: 'jquery', | ||
| jQuery: 'jquery', | ||
| 'window.jQuery': 'jquery', | ||
| }), | ||
| new webpack.optimize.CommonsChunkPlugin({ | ||
| children: true, | ||
| minChunks: 2, | ||
| }), | ||
| ], | ||
| resolve: { | ||
| alias: { | ||
| jquery: path.resolve(__dirname, 'node_modules/jquery/dist/jquery.min.js'), | ||
| jstree: path.resolve(__dirname, 'node_modules/jstree/dist/jstree.min.js'), | ||
|
There was a problem hiding this comment. both package.json's for jquery and jstree point to the their non-minified versions, this resolves to the minified versions instead |
||
| }, | ||
| }, | ||
| watch: false, | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this sets the public path for webpack to the base path for the cdn