Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront)L: BCTHEME-1366 Customer order summary with both physical and digital items shows shipping as null #2309

Merged
merged 1 commit into from
Jan 23, 2023
Merged

fix(storefront)L: BCTHEME-1366 Customer order summary with both physical and digital items shows shipping as null #2309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Removed non-working functionality from schema.json [#2301][https://github.com/bigcommerce/cornerstone/pull/2301]
- Refactored `hide_price_from_guests` logic around `show_cart_action` use [#2304](https://github.com/bigcommerce/cornerstone/pull/2304)
- Removed all Google AMP template files [#2308](https://github.com/bigcommerce/cornerstone/pull/2308)
- Customer order summary with both physical and digital items shows shipping as null [#2309](https://github.com/bigcommerce/cornerstone/pull/2309)

## 6.7.0 (11-03-2022)
- Fixed escaping on created store account confirm message. [#2265]https://github.com/bigcommerce/cornerstone/pull/2265
Expand Down
8 changes: 5 additions & 3 deletions templates/components/account/order-contents.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ <h3 class="account-heading">{{lang 'account.orders.details.order_contents'}}</h3
{{#each order.items}}
{{#if shipping_rows.length}}
{{#each shipping_rows}}
<li class="account-listShipping">
<h5 class="account-listShipping-title">{{lang 'account.orders.details.ship_to_multi' street=address city=city state=state zip=zip country=country}}</h5>
</li>
{{#if is_shipping}}
<li class="account-listShipping">
<h5 class="account-listShipping-title">{{lang 'account.orders.details.ship_to_multi' street=address city=city state=state zip=zip country=country}}</h5>
</li>
{{/if}}
{{/each}}
{{/if}}
<li class="account-listItem">
Expand Down