Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-492 Translation Gap: Compare page fields (Description, Rating and Availability). #2059

Merged
merged 2 commits into from
Jun 3, 2021
Merged

fix(storefront): BCTHEME-492 Translation Gap: Compare page fields (Description, Rating and Availability). #2059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9de0bad
fix(storefront): BCTHEME-492 Translation Gap: Compare page fields (De…
May 14, 2021
0ab9ceb
Merge branch 'master' into BCTHEME-492
BC-tymurbiedukhin Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Translation Gap: Compare page fields (Description, Rating and Availability). [#2059](https://github.com/bigcommerce/cornerstone/pull/2059)
- Translation Gap: Compare products error message. [#2061](https://github.com/bigcommerce/cornerstone/pull/2061)
- Translation Gap: Gift Certificate -> Code required message. [#2064](https://github.com/bigcommerce/cornerstone/pull/2064)
- Added translation for invalid quantity value error on Cart. [#2062](https://github.com/bigcommerce/cornerstone/pull/2062)
Expand Down
6 changes: 3 additions & 3 deletions templates/pages/compare.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ <h3 class="card-title">
</tr>
<tr class="compareTable-row">
<th class="compareTable-heading">
<span class="compareTable-headingText">Description</span>
<span class="compareTable-headingText">{{lang 'products.description'}}</span>
</th>
{{#each comparisons}}
<td class="compareTable-item">{{{ summary }}}</td>
Expand All @@ -89,7 +89,7 @@ <h3 class="card-title">
{{#if settings.show_product_rating}}
<tr class="compareTable-row">
<th class="compareTable-heading">
<span class="compareTable-headingText">Rating</span>
<span class="compareTable-headingText">{{lang 'products.reviews.rating_label'}}</span>
</th>
{{#each comparisons}}
<td class="compareTable-item">
Expand All @@ -104,7 +104,7 @@ <h3 class="card-title">
{{/if}}
<tr class="compareTable-row">
<th class="compareTable-heading">
<span class="compareTable-headingText">Availability</span>
<span class="compareTable-headingText">{{lang 'products.availability'}}</span>
</th>
{{#each comparisons}}
<td class="compareTable-item">
Expand Down