Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-104 Selecting product options doesn't update image on PDP in Internet Explorer #1913

Merged
merged 1 commit into from
Nov 25, 2020
Merged

fix(storefront): BCTHEME-104 Selecting product options doesn't update image on PDP in Internet Explorer #1913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Selecting product options doesn't update image on PDP in Internet Explorer. [#1913](https://github.com/bigcommerce/cornerstone/pull/1913)
- HTML Entity displayed as is via system/error message on a Storefront. [#1888](https://github.com/bigcommerce/cornerstone/pull/1888)
- Shoppers are not anchor-linked to reviews on PDPs if product description tabs are enabled. [#1883](https://github.com/bigcommerce/cornerstone/pull/1883)
- Fixed text contrast for brand name on Cart page. [#1882](https://github.com/bigcommerce/cornerstone/pull/1882)
Expand Down
2 changes: 1 addition & 1 deletion assets/js/theme/product/image-gallery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export default class ImageGallery {

if (isBrowserIE) {
const fallbackStylesIE = {
'background-image': `url(${this.currentImage.mainImageUrl}&ampimbypass=on)`,
'background-image': `url(${this.currentImage.mainImageUrl})`,
'background-position': 'center',
'background-repeat': 'no-repeat',
'background-origin': 'content-box',
Expand Down