feature(themes): BCTHEME-71 Add To Cart & Quick View buttons now appear when tabbing on product cards #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar when tabbing on product cards
|
Autotagging @bigcommerce/storefront-team @davidchin |
…ar when tabbing on product cards (remote linter fixes)
BC-tymurbiedukhin
suggested changes
Jul 23, 2020
There was a problem hiding this comment.
Generally, I think https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-within would be helpful in this situation (polyfill for IE will be needed)
…ar when tabbing on product cards (with polifill)
…ar when tabbing on product cards (remote linter)
BC-tymurbiedukhin
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
@BC-tymurbiedukhin @bc-alexsaiannyi
Add To Cart & Quick View buttons now appear when tabbing on product cards. Unfortunately this feature can not be done using only css because we can not affect parent elements. So when we have one button focused we can not remove transparency from class card-figcaption-body to make all buttons visible.
So I created event listener to check if focused element in card and show card-figcaption-body if it it true.
Also I changed tag of quick view button from to , because it is truly button
Tickets / Documentation
Ticket
Screenshots (if appropriate)
card_focus.zip