fix(bctheme): BCTHEME-8 Cornerstone v 4.1.1 - Product Image dimension… #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not constrained proportionally on Cart page which can lead to element overlapping
|
Autotagging @bigcommerce/storefront-team @davidchin |
junedkazi
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
@BC-tymurbiedukhin can you confirm this affects only cart page. What about product detail listing page ?
|
Changes has been applied for classes which are used only in components/cart/content.html file |
|
@BC-tymurbiedukhin I understand that the changes are specific to cart. But I am wondering if we need to make this change globally instead of doing a targeted fix. |
golcinho
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s not constrained proportionally on Cart page which can lead to element overlapping
What?
On the latest version of Cornerstone, larger product images are failing to be constrained proportionally to their parent div on the Cart page. This can lead to element overlapping with other line-items in the cart.
Expanding this ticket to mention that these symptoms are also present in the Cart Quick-View modal.
Tickets / Documentation
https://jira.bigcommerce.com/browse/BCTHEME-8
Screenshots (if appropriate)
ping @yurytut1993 @bc-alexsaiannyi @junedkazi @golcinho