fix(bctheme): BCTHEME-18 Cornerstone - Text logos truncated when view… #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed on mobile devices and smaller browser sizes
|
Autotagging @bigcommerce/storefront-team @davidchin |
yurytut1993
reviewed
Jul 10, 2020
Comment on lines
74
to
75
| margin-right: auto; | ||
| margin-left: auto; |
There was a problem hiding this comment.
can we replace it to
margin: 0 auto; ?
yurytut1993
reviewed
Jul 10, 2020
| @@ -65,11 +68,14 @@ | |||
| > a { | |||
There was a problem hiding this comment.
Can we replace tag selector on class selector? I know that is not part of your ticket, but if it is fast - will be great
golcinho
approved these changes
Jul 10, 2020
yurytut1993
approved these changes
Jul 10, 2020
junedkazi
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed on mobile devices and smaller browser sizes
What?
Using Cornerstone, text logos are being cut off on mobile devices and smaller window sizes.
Now logo is responsive due to depending on vw.
Tickets / Documentation
https://jira.bigcommerce.com/browse/BCTHEME-18
Screenshots (if appropriate)
responsive-text-logo.mov video is attached to the ticket
ping @golcinho @yurytut1993 @bc-alexsaiannyi @junedkazi