feature(bctheme): BCTHEME-50 ability to load subcategories and expand them if there are other categories beneath it #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…them if there are other categories beneath it (not affecting alternate menu)
…hem if there are other categories beneath it (styles code optimization)
|
Autotagging @bigcommerce/storefront-team @davidchin |
There was a problem hiding this comment.
Everything is ok, but I suggest to move arrow on the right side of menu, @bc-as what do you think?
it will not be a problem |
@BC-tymurbiedukhin moved arrow to the right. made some code updates for it
|
… them if there are other categories beneath it - mob version ux update
… them if there are other categories beneath it - affecting fixes
… them if there are other categories beneath it (dafault menu mob/desktop fixes)
… them if there are other categories beneath it (alternate menu affects fix)
|
@BC-tymurbiedukhin @bc-as @golcinho made updates for mobile menu styles that were discussed with designers
|
|
@yurytut1993 lgtm |
golcinho
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
@BC-tymurbiedukhin @junedkazi @golcinho
In Cornerstone we have mobile menu with nested categories if they exist. For now we can not go to the subcategory page if it has its own subcategories (has arrow to dropdown). I have created a wrapper for arrow and replaced data attributes from link on this wrapper. Javascript uses this attributes to open/close nested subcategories.
So now link is responsible for redirect and arrow responsible for open/close nested subcategories. Also I updated icon wrapper styles to stretch it to the end of the row for comfortable toggling nested categories.
Styles wrote carefully and not affecting alternate menu styles (by default in config.json navigation_design option value is simple).
Tickets / Documentation
In Ticket you can see 2 videos (before_menu_links_update and after_menu_links_update) to better understand the result