fix(BC Themes): BCTHEME-12 Cornerstone: Enabling Facebook Likes causes iframe overlap in WYSIWYG #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s iframe overlap in WYSIWYG
|
Autotagging @bigcommerce/storefront-team @davidchin |
junedkazi
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Cornerstone: Enabling Facebook Likes causes iframe overlap in WYSIWYG.
Facebook Likes causes iframe with like button overlap Description section. Because of that you can not interact with product description text and and follow links in this description.
As I understood from the https://developers.facebook.com/docs/plugins/like-button styles of a like button can be modified from the third side. So changing the styles of its iframe may cause unpredictable style effects. So I decided that overriding iframe styles is not the best decision. It is more reliable to set z-index for description under the like button to shift this description in higher layer and make it clickable.
Tickets / Documentation
Here is task where we have screenshot with a bug. And also I added video with bug reproducing and video with fix